Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #120] fix conflict between the naming of material.SearchBar and ume's SearchBar. #122

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

Atsumi3
Copy link
Contributor

@Atsumi3 Atsumi3 commented Jun 6, 2023

Issue: #120

There was a conflict between the naming of material.SearchBar and ume's SearchBar.
https://api.flutter.dev/flutter/material/SearchBar-class.html

Pull Request Checklist

  • I have read the UME contribution document and understand how to contribute, commit the code according to the rules. 我已阅读过 UME 贡献文档,并了解如何进行贡献,按照规则提交了代码
  • I have added the necessary comments in code to ensure that other contributors can understand the reason for the change. 我在修改中已经添加了必要的注释,以确保便于其他贡献者理解修改原因
  • The code has been formatted by dartfmt before push. 代码在提交前已经经过 dartfmt 进行了格式化
  • Change does not involve the adjustment of test cases. Or all existing and new tests are passing. 改动不涉及测试用例调整,或 example 工程与单元测试已经完全跑通

If you need help, consider Join ing the ByteDance Flutter Exchange Group.

如有任何问题,可以加入字节跳动 Flutter 交流群

Or contact author.

或随时联系开发者

@Atsumi3 Atsumi3 changed the title fix conflicted SearchBar [Issue #120] fix conflict between the naming of material.SearchBar and ume's SearchBar. Jun 6, 2023
@Atsumi3
Copy link
Contributor Author

Atsumi3 commented Jun 6, 2023

There was no problem in the develop* branch, so it is a PullRequest to master.

@brave723
Copy link

ume SearchBar不能换个名字?

@jixiaoyong
Copy link

还有个稍微简略点的改法,使用 hide 隐藏掉第三行的 material.dart 中的SearchBar:

import 'package:flutter/material.dart' hide SearchBar;

@Moshimol
Copy link

在哪里文件里呢?

@talisk talisk merged commit ad520b5 into bytedance:master Sep 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants