Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Report Card result D #3

Closed
wangkechun opened this issue May 31, 2021 · 2 comments
Closed

Go Report Card result D #3

wangkechun opened this issue May 31, 2021 · 2 comments
Labels
wontfix This will not be worked on

Comments

@wangkechun
Copy link

image
@wangkechun
Copy link
Author

https://goreportcard.com/report/github.com/bytedance/sonic#gofmt

@chenzhuoyu
Copy link
Member

Most of the report are code-style "issues", in fact, I consider none of them as "issues". Programs are suppose to be readable by human, not machine.

We will fix those non-code-style issues.

Also, JIT engine is no regular Go code, linting them with regular rules might not be a good idea.

@chenzhuoyu chenzhuoyu added the wontfix This will not be worked on label May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wangkechun @chenzhuoyu