Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip number and tolower in native c #520

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix: skip number and tolower in native c #520

merged 2 commits into from
Sep 5, 2023

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Sep 4, 2023

No description provided.

@liuq19
Copy link
Collaborator Author

liuq19 commented Sep 4, 2023

This fixed #507

@liuq19 liuq19 marked this pull request as draft September 4, 2023 13:08
@liuq19 liuq19 marked this pull request as ready for review September 5, 2023 02:03
@liuq19 liuq19 changed the title fix: skip number in native c fix: skip number and tolower in native c Sep 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #520 (bf30d5f) into main (6c2a723) will decrease coverage by 0.56%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   73.79%   73.23%   -0.56%     
==========================================
  Files          63       60       -3     
  Lines        8288     8025     -263     
==========================================
- Hits         6116     5877     -239     
+ Misses       1847     1836      -11     
+ Partials      325      312      -13     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AsterDY AsterDY merged commit 61ca8ba into main Sep 5, 2023
30 checks passed
@AsterDY AsterDY deleted the fix/skipnum branch September 5, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants