Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: encoder VM #593

Merged
merged 7 commits into from Feb 18, 2024
Merged

opt: encoder VM #593

merged 7 commits into from Feb 18, 2024

Conversation

AsterDY
Copy link
Collaborator

@AsterDY AsterDY commented Feb 11, 2024

Optimizations

  • append chars instead of string
  • use std strconv.AppendInt() instead of native I64toa
  • force inline call_xx_marshaler()
  • asm2arm: use dynamic PC-relative offset JUMP to replace CALL

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (820917d) 61.58% compared to head (ed746bd) 61.80%.

Files Patch % Lines
internal/encoder/vm/vm.go 2.56% 38 Missing ⚠️
internal/encoder/alg/spec.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           test/aarch64     #593      +/-   ##
================================================
+ Coverage         61.58%   61.80%   +0.22%     
================================================
  Files                84       84              
  Lines             10363    10345      -18     
================================================
+ Hits               6382     6394      +12     
+ Misses             3597     3568      -29     
+ Partials            384      383       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsterDY AsterDY merged commit 14b90fc into test/aarch64 Feb 18, 2024
12 of 24 checks passed
@AsterDY AsterDY deleted the opt/enc_vm branch February 18, 2024 05:00
liuq19 pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants