Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

check-running-kernel: Add support for ZSTD compression #91

Closed
wants to merge 1 commit into from

Conversation

amotl
Copy link

@amotl amotl commented Mar 12, 2022

Dear Bernd and Jan,

first things first: Thanks a stack for conceiving and maintaining this collection of fine monitoring plugins.

As this is our very first contribution to Debian, please bear with us 1. We recently discovered the check_running_kernel program and are now running it on 40+ machines. This is not that much, but it was enough diversity to give us the opportunity to discover some minor shortcomings, mostly on machines running derivate, non-vanilla Debian distributions like Proxmox and Ubuntu.

  • First, we found that a modern Debian bullseye-based PVE/Proxmox machine already used a Linux kernel with ZSTD compression which was not supported yet.
  • Secondly, we discovered that on the same Proxmox machine, and on another vanilla Ubuntu 20.04 machine, both running 5.x Linux kernel versions, there was a suffix added to the on-disk kernel image, which we stripped off using sed in order to satisfy the comparison operation. You can find more details about this topic in the comment section below. I've diverted this topic to check-running-kernel: Compensate for CONFIG_VERSION_SIGNATURE suffix #92 in order to keep things separate.

We hope you like those improvements and ask you to let us know about any adjustments you would like to see.

With kind regards,
Andreas.

/cc @Tonkenfo

Footnotes

  1. While we just also signed up to https://salsa.debian.org/, we discovered this repository also on GitHub and found that both of you might be exchanging patches between here and https://salsa.debian.org/nagios-team/pkg-nagios-plugins-contrib already. So, we are submitting this patch to this repository. If this is wrong, please advise different places where to submit this patch.

@amotl amotl force-pushed the amo/improve-running-kernel branch from 623673d to 112b0f2 Compare March 13, 2022 15:14
@amotl amotl force-pushed the amo/improve-running-kernel branch from 112b0f2 to f97a119 Compare March 13, 2022 16:05
@amotl amotl changed the title check-running-kernel: Add support for ZSTD compression, fix Ubuntu and Proxmox check-running-kernel: Add support for ZSTD compression Mar 13, 2022
@waja
Copy link
Collaborator

waja commented Mar 31, 2022

I can confirm this issue

Copy link
Collaborator

@waja waja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

while the change seems to be fine, the zstd binary is needed to work. Maybe you can also adjust the following in your changes?

        if ! which ${filter%% *} >/dev/null; then
                echo "UNKNOWN: filter command '$filter' missing, perhaps install xz-utils, lz4 or lzop?" >&2
                exit $UNKNOWN
        fi

Thanks, Jan.

@waja
Copy link
Collaborator

waja commented Jan 17, 2023

Superseeded by #94

@waja waja closed this Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants