-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix case for "clCfg" in Release Notes in the instructions for breaking changes [v0.9.28] #105
Comments
Hey. Sorry to hear about the confusion. I almost sent you a specific update recommendation, too (I sent one to #103 (comment)). I can see the confusion in that I say TYPE.FIELD for the general but INSTANCE.FIELD for the specific, but I do say INSTANCE.FIELD in the two examples on the right hand side right after the general. I realize capital and lowercase C are very similar in most fonts, though "cl" for "command-line" is an ancient and well known abbreviation (most often used as the start of CLI). I wasn't sure how to emphasize that you don't have to use the convenience global (edit: markdown ate my bracketed tokens.) |
Also, linked in that #103 (comment) you see a new |
Understood, I read your notes in hurry.
I use |
Ah. Fine point re: best of both worlds version strings. I updated the example in I'm open to re-wording suggestions on the RELEASE_NOTES, but if you don't have anything, we can maybe close the issue. No rush, though. It's hard to explain some things and confusion is in some ways a fleeting and precious resource. :-) |
Yeah. You & I are pretty in sync in the literal sense! I was thinking that as I pressed enter and saw the update. |
Also, I'm unsure if a "like/emoji" use on a thread is sufficient to get you and @pb-cdunn notified about the just-closed very long standing issue #2 / #30. So, I'll mention it here in case you're interested. Probably best to reply on one of those threads if you reply. I think 3-ish years ago when it first surfaced one could get the doc comments for fields out of the AST to avoid duplication in the new Also, if anyone has any thoughts of how I can avoid the |
Never mind about the |
Hello,
I was a bit confused when the instructions for fixing the backward-incompatible changes in the Release Notes didn't work: https://github.com/c-blake/cligen/blob/master/RELEASE-NOTES.md#version-0928
Then looking into the tests, I realized that I need to do
clCfg.version
, and notClCfg.version
.btw thanks for continually maintaining and updating this package!
The text was updated successfully, but these errors were encountered: