Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recalculate filter only when switching or changing settings #135

Open
NinthDesertDude opened this issue Jan 17, 2022 · 2 comments
Open

recalculate filter only when switching or changing settings #135

NinthDesertDude opened this issue Jan 17, 2022 · 2 comments

Comments

@NinthDesertDude
Copy link

Please recalculate the filter only when switching or changing settings. From the QT window opened for a paint.net integration of gmic-qt, the filter is unnecessarily recomputed in all of these situations:

  • panning the preview image
  • right-clicking items in the filter list
  • selecting an option from the context menu that opens after right-clicking an item in the filter list
  • left-clicking the same filter that's currently selected

For both speed and preserving the current seed in cases where randomization is involved with a filter, it's best to avoids these unnecessary renders. Adding/removing the currently-selected filter from favs is probably another case.

@dtschump
Copy link
Collaborator

Agree with most points, except "panning the preview image" that requires the preview to be recalculated.
The preview image is calculated only from the thumbnail it displays, not from the entire image (would take too much time for a preview, most of the time).

@Reptorian1125
Copy link

On preview image being recalculated, I think that is a fair point on it taking long. There is some filters that needs the whole image or at least some information from the whole image if possible (dimensions, or statistics). On just being able to get partial information, it would allow for accurate preview for some few filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants