Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing can crash monsterwm #10

Closed
mil opened this issue Jul 13, 2012 · 2 comments
Closed

Resizing can crash monsterwm #10

mil opened this issue Jul 13, 2012 · 2 comments

Comments

@mil
Copy link

mil commented Jul 13, 2012

If you resize in tiling mode there is no catch to see if you are setting W/H of XMoveResizeWindow() to 0. Thus it is possible to crash monsterwm while resizing. To see this happen: Start monsterwm, launch two windows. Hold down Alt+l. When a window is calculated as 0 width, monsterwm will crash.

See my fix here:
mil@5e104b4

@c00kiemon5ter
Copy link
Owner

the check is against MINWMSZ (aka minimum window size).
there was a wrong logic operator there.
thanks for catching and reporting this ;)

closed by fixed commit 534c8e5d8d1d654ae52a0b1f10a24baec7c18739

@c00kiemon5ter
Copy link
Owner

btw, this can happen with stack resize too.
there is no checking there, but making windows so small
doesn't make much sense or make them any useable.

I should probably add size checks there too.
I've commented on this on the arch forums, and iirc on that commit (which, tbh, might have been rebased)

keep in mind that some apps (ie gvim) need a minimum size that is far greater than 1px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants