Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 Branch for Tio #7

Closed
AndrewSav opened this issue Apr 3, 2017 · 2 comments
Closed

v1 Branch for Tio #7

AndrewSav opened this issue Apr 3, 2017 · 2 comments

Comments

@AndrewSav
Copy link
Contributor

I'm wondering if it's possible to host the v1 branch for TriItOnline in this repository, rather than on TIO's one.

Currently we have this branch in TIO repo:

https://github.com/TryItOnline/Fission/commits/v1

It has two additional commits as commits as compared to what's in this official repository:

  • changes for the linux compilers not to choke on the sources
  • memory corruption fix by Martin, which was eventually integrated in v2

These two things were needed to run v1 on TIO.

Would you be interested in making a v1 branch in this repo and apply these changes to it, so TIO could you that as the base for v1.

There is also a pull requests I just opened for the changes that TIO needs for v2, this is separate. Can it be merged as well? #6

Thank you in advance!

@C0deH4cker
Copy link
Owner

Hi! I can probably get to these in a week or two (I'm quite busy with school and other obligations right now). I actually wasn't aware that people were actually still using Fission. I might pick up this project and add more to it if people still seem interested.

@C0deH4cker
Copy link
Owner

Sorry for the delay, but I've just backported those fixes from Fission 2 to the v1 branch and released the new version as 1.0.1 (tagged). I've also merged your pull request for Fission 2. Let me know if there's anything else you need me to do to help getting Fission working in TIO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants