Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py has unexpected content #5

Closed
Hackndo opened this issue Jan 12, 2021 · 1 comment
Closed

setup.py has unexpected content #5

Hackndo opened this issue Jan 12, 2021 · 1 comment

Comments

@Hackndo
Copy link

Hackndo commented Jan 12, 2021

Hello,
I see that setup.py file as actually some system command running as sudo, which is not a good practice.

setup.py is a well known file for packaging python applications (https://packaging.python.org/tutorials/packaging-projects/) and it should be used as so.

Running sudo pip via os.system should absolutely be removed, as it installs libraries for root user, even if the current user has a virtual environment.

I will probably try and use it when it's well packaged :)

Keep up the good work!

@c0dejump
Copy link
Owner

c0dejump commented Feb 23, 2021

Hello,

Ah yes, you're right, it fixed thanks !

Don't hesitate if you have another comment or advices :)

Thanks,
Best regards.

@c0dejump c0dejump closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants