Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call onhide on each tooltip hide #1818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnsudaar
Copy link

The onhide method of the tooltip api is only called when the tooltip is closed from the api.
This PR call this methods when the tooltip is closed from the api or from an internal reason.

@codecov-io
Copy link

Current coverage is 64.03% (diff: 100%)

Merging #1818 into master will decrease coverage by 0.01%

@@             master      #1818   diff @@
==========================================
  Files             1          1          
  Lines          4400       4401     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2818       2818          
- Misses         1582       1583     +1   
  Partials          0          0          

Powered by Codecov. Last update 223404a...5294ba6

@impronunciable
Copy link

@johnsudaar thank you for your contribution.

Before merging this we'll need you to add automated tests for this issue.

@axe-me
Copy link

axe-me commented Feb 8, 2018

and same thing to onshow event, fix please. :)

@panthony panthony added the R-needs-tests Request for changes: The PR needs tests label Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R-needs-tests Request for changes: The PR needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants