Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to campaign from dashboard #47

Closed
bzekanovic opened this issue Apr 7, 2022 · 8 comments
Closed

Add link to campaign from dashboard #47

bzekanovic opened this issue Apr 7, 2022 · 8 comments
Labels
fix pending Issue is resolved in a non-main branch

Comments

@bzekanovic
Copy link

  1. Any way this message can be removed or updated when campaign is running "No status reports received. Nodes may have errored out" with something more accurate?
    image

  2. Manage Campaigns page should also include "Start" function since right now you can only execute "Cancel / Delete" functions from that page.

  3. Any way to remove hyperlink to AWS EC2 instance that is shown on dashboard and add hyperlink to related campaign?
    image

@c6fc
Copy link
Owner

c6fc commented Apr 8, 2022

  1. That's precisely the state of the campaign - I can hide the 'Nodes may have errored out' piece for a bit, but if you have more specific suggestions, I'm all ears.
  2. This is intentional.
  3. I plan to link this to the instance log. I can add a separate link to the campaign though, that's a good idea.

@c6fc c6fc changed the title NPK v3 UI Improvements Add link to campaign from dashboard Apr 8, 2022
@bzekanovic
Copy link
Author

  1. Maybe replace it with something that would encourage users to check output logs to determine state of each instance. You already gave them all info they need to determine if spot is rejected / hashcat job failed via spot fleet request history and output logs. I would even leverage that "Campaign Manifest and Outputs" to link to individual instance output logs, cracked hashes files etc.... so its all in one place. See what works for you on your end.
  2. Got it
  3. Sounds good.

@c6fc
Copy link
Owner

c6fc commented Apr 11, 2022

Added in dev

@c6fc c6fc added the fix pending Issue is resolved in a non-main branch label Apr 11, 2022
@bzekanovic
Copy link
Author

I did notice message below at first, but it did go away after I refreshed my browser page and nicer UI status metrics showed up.

image

@c6fc
Copy link
Owner

c6fc commented Apr 11, 2022

Ahh, I'd forgotten to remove a debug string. It's gone now though.

This is why dev exists 😂

@bzekanovic
Copy link
Author

I'll start testing this.

Also, it would not be bad idea to show end users how to run dev branch directly from CloudShell via source <(curl https://npkproject.io/cloudshell_install_dev.sh) in your docs. I had to dig it up in your prod script, but something to mention in docs.

@bzekanovic
Copy link
Author

You can merge this one whenever you are ready and close. thx

@c6fc
Copy link
Owner

c6fc commented Apr 23, 2022

Merged

@c6fc c6fc closed this as completed Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pending Issue is resolved in a non-main branch
Projects
None yet
Development

No branches or pull requests

2 participants