Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the transcript summary URL configurable in the mutations tab #2885

Merged
merged 1 commit into from Nov 20, 2019

Conversation

onursumer
Copy link
Member

Fix cBioPortal/cbioportal/issues/6828.

Related PR in the react-mutation-mapper repo: cBioPortal/react-mutation-mapper/pull/125.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@alisman alisman merged commit 51a611a into cBioPortal:master Nov 20, 2019
@onursumer onursumer deleted the custom-ensembl-transcript-url branch November 20, 2019 17:03
@inodb inodb added the feature label Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants