Add Ensembl URL template property #6870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
@SRodenburg We currently allow using multiple genome builds in a single version of cBioPortal so it might actually be necessary to be able to set this for a particular genome build. Or maybe we should add it to the genome nexus e.g. as part of the ensembl transcript response or something. I think most people currently only use one genome build per instance so let's do it this way for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@onursumer adjusted the frontend code to make the Ensembl Transcript URL in the Mutations tab customizable (see cBioPortal/cbioportal-frontend#2885 and #6828).
This PR contains corresponding backend changes.
ensembl.transcript_urlis parsed fromportal.properties, and forwarded to the frontend.Successfully tested on local frontend deploy.