New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add splice and driver annotation mutation type selector #3704
Conversation
e1493b1
to
a65fe4c
Compare
357d7a6
to
2a4f5dc
Compare
@jjgao @inodb Here are some mockup for driver annotation setting button, personally I like the first one most so add it to test link above, let me know which one do you prefer |
I like 2 :) - good to keep it consistent with the button at the top |
Can we remove the "Other" Category when it is 0? |
c462979
to
98dee60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There seems to be a bug with the table search. Mutation type counts are not updated anymore after a search. Other than that the PR looks good to me.
'-' | ||
); | ||
|
||
const geneSummaryInfo = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add two functional components GeneSummaryInfo
and CompactGeneSummaryInfo
to keep the render function shorter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I move them outside render, but adding two functional components might introduce some duplicated code(some calculation code in both GeneSummaryInfo
and CompactGeneSummaryInfo
), so I just make them as one component
<div | ||
data-test="germlineMutationRate" | ||
className="invisible" | ||
style={{ display: 'none' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember we didn't want { display: 'none' }
because we wanted to render certain elements always at a fixed location. But now we are switching to a compact view, probably it's okay to do it this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fix: cBioPortal/cbioportal#8437
splice
in mutation type selector