Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patient clinical attributes not shown in all patient samples #4451

Closed
oplantalech opened this issue Jul 13, 2018 · 5 comments
Closed

Patient clinical attributes not shown in all patient samples #4451

oplantalech opened this issue Jul 13, 2018 · 5 comments
Labels

Comments

@oplantalech
Copy link
Contributor

As you can see in the screenshot for study lgg_ucsf_2014 in cbioportal.org, patient attributes like "Gender" are only displayed in one of the samples of the patient, but not in all:
example

@inodb
Copy link
Member

inodb commented Jul 13, 2018

I think gender is a patient attribute. I don't see it on the patient view for the samples. @zhx828 do you know why it shows up this way?

Is there some logic on the frontend that assigns the gender to one sample?

@zhx828
Copy link
Member

zhx828 commented Jul 13, 2018

@inodb the patterns looks like only the first sample got the gender info. Yeah, the clinical table will map all patient clinical data to sample level. I can take a look at the issue.

@kalletlak
Copy link
Member

@zhx828 I was running into errors when there is only one sample in the study. My fix in cBioPortal/iViz#739 even fixes this

@zhx828
Copy link
Member

zhx828 commented Jul 13, 2018

@kalletlak I doubt it will because the logic of mapping P to S data is in cbioportal, separated out from iviz project. Let me take a look.

@zhx828
Copy link
Member

zhx828 commented Jul 13, 2018

@kalletlak looks good. It does solve the issue. I will send the pull request to portal.

zhx828 pushed a commit to zhx828/cbioportal that referenced this issue Jul 13, 2018
@zhx828 zhx828 closed this as completed Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants