Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 1-sided fisher exact test to two-sided #9943

Closed
3 tasks done
inodb opened this issue Dec 22, 2022 · 1 comment · Fixed by #10288
Closed
3 tasks done

change 1-sided fisher exact test to two-sided #9943

inodb opened this issue Dec 22, 2022 · 1 comment · Fixed by #10288

Comments

@inodb
Copy link
Member

inodb commented Dec 22, 2022

In both the Mutual Exclusivity tab and the Comparison page/tab, we use 1-side Fisher's Exact test. Two-sided is more appropriate:

  • fix for mutual exclusivity tab
  • fix for comparison tab
  • update faq (see comment)

Some anonymous feedback on this from others:

  • I actually noticed that in the portal it uses the one-sided but in papers, I've seen two-sided and that's what i personally use. You're predicting the direction of the effect with one-sided, something i'm not sure how you can do in this situation. with directionality (one sided) the pvalue is half the 2 sided pvalue so more samples will pass FDR cutoffs (in laymans terms). (caveat: I'm not a stats expert )
  • I agree with the above, I always use a two-sided test in this setting
  • Generally speaking, a two-sided test is almost always more appropriate

And user that raised it: https://groups.google.com/g/cbioportal/c/WbPzItsK_Vc/m/wlTdzmf3AQAJ

Question: T-test for continuous data (mRNA tab and protein tab), should we use two sided here as well? Maybe create follow-up ticket?

@Eric-Jiang1
Copy link

working on this issue, will get back to you tomorrow on Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants