Two sided fishers test #10118

Eric-Jiang1 · 2023-04-05T18:39:20Z

Partially addresses #9943 (group comparison)

Describe changes proposed in this pull request:

Changed CalcFisherExactTest.java to use the two-sided Fisher's exact test value
Also changed OddsRatio.java, EnrichmentsAnalysisUtil.java to use the two-sided Fisher's exact test value
Documented reasoning behind change in CalcFisherExactTest.java and FisherExact.java so future developers know that in general we prefer the two-sided Fisher's exact test

Checks

Runs on heroku
Has tests or has a separate issue that describes the types of test that should be created. (Going to create a separate issue about testing, there's a lack of testing for FisherExact.java functions in general)
The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section! (This PR is not adding logic based on one or more clinical attributes)