Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move treatments endpoint to internal API #10505

Conversation

jagnathan
Copy link
Collaborator

@jagnathan jagnathan commented Dec 22, 2023

Move Treatments Endpoint to Internal API - fix cBioPortal/icebox#561

Note:

  • API endpoints stay at the same location, just in certain clients they might have to refer to the endpoint now via internal instead of public

move treatments endpoint to internal API fix#10345
@jagnathan
Copy link
Collaborator Author

Move Treatments Endpoint to Internal API - fix cBioPortal/icebox#561

Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alisman
Copy link
Contributor

alisman commented Jan 22, 2024

@jagnathan is this ready for review? This will probalby require a frontend change so lets be careful about that.

@jagnathan
Copy link
Collaborator Author

@alisman this is ready for review. as per my understanding, the frontend change is automatic. the API endpoint will move into internal section of the Swagger Doc. Are there other changes required on frontend?

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you!

@inodb inodb merged commit 4d54944 into cBioPortal:master May 3, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move treatments endpoint to internal
3 participants