Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo 6.0.0 #10532

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Demo 6.0.0 #10532

merged 6 commits into from
Jan 10, 2024

Conversation

JREastonMarks
Copy link
Collaborator

@JREastonMarks JREastonMarks commented Jan 10, 2024

Fix issues with 6.0.0 RC deployment.
Includes proxy fixes
Fixes Swagger
Adds Sentry
Other smaller fixes

Copy link

sonarcloud bot commented Jan 10, 2024

# Swagger Configuration
springdoc.swagger-ui.disable-swagger-default-url=true
springdoc.swagger-ui.path=/api/swagger-ui
springdoc.api-docs.path=/api/v2/api-docs
Copy link
Member

@inodb inodb Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel slightly uncomfortable about making this the default in the EXAMPLE properties: springdoc.api-docs.path=/api/v2/api-docs. As I guess it is actually v3 of the api-docs. Might be cleaner if we can somehow serve both /api/v3/api-docs and /api/v2/api-docs . Wondering if in the future we can prevent this by just having e.g. a /api/api-docs. Anyway can be follow up ticket, filed one here: #10534. Prolly ok for now

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! Added a follow up ticket re the change in API docs url

@inodb inodb merged commit 5583841 into master Jan 10, 2024
19 of 21 checks passed
@inodb inodb deleted the demo-6.0.0 branch January 10, 2024 22:59
@inodb inodb restored the demo-6.0.0 branch January 11, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants