Remove spring-boot-starter-data-mongodb #10562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after this fix did it still fail on your alpine-based docker image? |
|
The proposed change fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 6.0.0 cBioPortal ships with spring-boot-starter-data-mongodb which includes the mongodb java client in currently version 4.9.1.
cBioPortal still uses 3.12.14. The APIs of both are incompatible to each other. Depending on your java version and it's lib strategy this can cause a
Method not founderror. On my workstation I had no issues, but using a alpine-based docker image I ran into this issue.So I suppose to remove the spring-boot one for now. In addition I think that using the version of mongodb that ships with spring-boot only makes sense if the spring-boot versions between cBioPortal and session-service are aligned (which they aren't at the moment).