Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RedisAutoConfig Exclusion logic #10728

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

haynescd
Copy link
Collaborator

Currently If users wanted to just configure Spring Redis Session it was impossible with out enabling redis cache type.

Updated conditional logic to look at the presence of spring.data.redis.host instead

@haynescd haynescd added the bug label Mar 29, 2024
@haynescd haynescd self-assigned this Mar 29, 2024
Copy link
Collaborator

@JREastonMarks JREastonMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haynescd
Copy link
Collaborator Author

going to update this to use this property instead
spring.session.store-type=redis

Comment on lines -400 to -401
## Comment out the line below to enable redis caching
spring.autoconfigure.exclude=org.springframework.boot.autoconfigure.data.redis.RedisAutoConfiguration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this going to cause an issue in our prod environment? I think we're still using .EXAMPLE for defaults?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be needed anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should exlude RedisAutoConfig if the property is not present

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - thanks!

Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@haynescd haynescd merged commit 8361b0a into master Apr 1, 2024
16 of 18 checks passed
@haynescd haynescd deleted the bugfix/Fix-Redis-SessionAutoConfi branch April 1, 2024 20:29
@inodb inodb changed the title 🐛 Fix RedisAutoConfig Exclusion logic to exclude if redis session… 🐛 Fix RedisAutoConfig Exclusion logic Apr 30, 2024
@inodb inodb changed the title 🐛 Fix RedisAutoConfig Exclusion logic Fix RedisAutoConfig Exclusion logic Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants