Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent Cache Timestamp API #6798

Merged
merged 1 commit into from Nov 20, 2019
Merged

Persistent Cache Timestamp API #6798

merged 1 commit into from Nov 20, 2019

Conversation

Luke-Sikina
Copy link
Member

Fix #6635

Describe changes proposed in this pull request:

  • New endpoint
    • For every table that has endpoints that are being persistently
      cached the endpoint returns a table name timestamp pair of the
      last time the table was updated
    • If the table has never been updated, it instead returns
      the creation date of the table
  • This feature requires SQL 5.7.2+ because the InnoDb engine did not
    update this column correctly before then
    • updated the requirements in the docs to require 5.7 rather than 5.x

Checks

  • Runs on heroku
  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.

@inodb inodb requested a review from onursumer November 11, 2019 17:42
@jjgao jjgao temporarily deployed to cbioportal-hg19cache-6imcgpdrw November 11, 2019 17:47 Inactive
@jjgao jjgao temporarily deployed to cbioportal-hg19cache-6imcgpdrw November 11, 2019 19:00 Inactive
@jjgao jjgao temporarily deployed to cbioportal-hg19cache-6imcgpdrw November 12, 2019 20:44 Inactive
@jjgao jjgao requested a review from n1zea144 November 13, 2019 22:40
@Luke-Sikina
Persistent Cache Timestamp API
8b5147f 
- New endpoint
    - For every table that has endpoints that are being persistently
    cached the endpoint returns a table name timestamp pair of the
    last time the table was updated
    - If the table has never been updated, it instead returns
    the creation date of the table
- This feature requires SQL 5.7.2+ because the InnoDb engine did not
update this column correctly before then
    - updated the requirements in the docs to require 5.7 rather than 5.x
@jjgao jjgao temporarily deployed to cbioportal-hg19cache-6imcgpdrw November 19, 2019 16:05 Inactive
@n1zea144 n1zea144 merged commit a5c2a65 into cBioPortal:master Nov 20, 2019
@inodb inodb added the api label Nov 22, 2019
@Luke-Sikina Luke-Sikina deleted the hg19cache branch November 27, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodb inodb inodb left review comments

@n1zea144 n1zea144 n1zea144 approved these changes

@jjgao jjgao Awaiting requested review from jjgao

@onursumer onursumer Awaiting requested review from onursumer

Assignees
No one assigned
Labels
api ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reference genome genes endpoint is a bottleneck
4 participants
@Luke-Sikina @n1zea144 @inodb @jjgao