Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "skin.right_nav.show_whats_new" to config_service.jsp #6809

Merged
merged 1 commit into from Nov 18, 2019

Conversation

ngocnn1104
Copy link
Contributor

Added skin.right_nav.show_whats_new to config_service.jsp to control the display of "What's new" component in the front-end.

Copy link
Contributor

@oplantalech oplantalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR tested, and it works. Thanks, @ngocnn1104 !

@oplantalech
Copy link
Contributor

@jjgao Can you merge this PR?

@inodb
Copy link
Member

inodb commented Nov 14, 2019

Thank you @oplantalech and @ngocnn1104! Could you elaborate what the difference is with setting skin.right_nav.whats_new_blurb to empty and update the docs accordingly? I guess it currently shows the cBioPortal Twitter when skin.right_nav.whats_new_blurb is empty? Thanks!

@jjgao jjgao temporarily deployed to cbioportal-configservic-livfqz November 14, 2019 15:46 Inactive
@oplantalech
Copy link
Contributor

@inodb Is it confusing in the documentation? Currently it states:

Settings controlling the "What's New" blurb in the right navigation bar: you can add any HTML code here that you want to visualize. If the field is left empty, the Twitter timeline will be shown (as long as skin.right_nav.show_whats_new is true, otherwise this section will not be displayed).

So as you mentioned, if you leave skin.right_nav.whats_new_blurb empty, and skin.right_nav.show_whats_new=true, then the "What's new" blurb will show the Twitter timeline. If skin.right_nav.show_whats_new=false, the section will not be shown (regardless of the content of skin.right_nav.whats_new_blurb).

The problem that this PR fixes is that skin.right_nav.show_whats_new=false was still showing the "What's new" section.

@jjgao
Copy link
Member

jjgao commented Nov 18, 2019

@inodb please feel free to merge once you approve.

@inodb
Copy link
Member

inodb commented Nov 18, 2019

@oplantalech thanks for elaborating!

@inodb inodb merged commit a275173 into master Nov 18, 2019
@inodb inodb added the bug label Nov 18, 2019
@inodb inodb deleted the configService_showWhatsNew branch December 2, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants