Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News for 3.1.6 #6873

Merged
merged 1 commit into from
Nov 29, 2019
Merged

News for 3.1.6 #6873

merged 1 commit into from
Nov 29, 2019

Conversation

jjgao
Copy link
Member

@jjgao jjgao commented Nov 29, 2019

news

Describe changes proposed in this pull request:

  • news for 3.1.6

Checks

  • Runs on heroku
  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

NA

Notify reviewers

NA

@jjgao jjgao requested a review from inodb November 29, 2019 19:38
@jjgao jjgao temporarily deployed to cbioportal-jjgao-patch-n7bvamt November 29, 2019 19:39 Inactive
@inodb
Copy link
Member

inodb commented Nov 29, 2019

@jjgao thanks for adding this! Good idea to also add a news item for smaller releases

@jjgao
Copy link
Member Author

jjgao commented Nov 29, 2019

@inodb thanks. Wondering if we can automate this...

@jjgao jjgao merged commit c9fc092 into master Nov 29, 2019
@jjgao jjgao deleted the jjgao-patch-2 branch November 29, 2019 20:57
@inodb
Copy link
Member

inodb commented Nov 30, 2019

@jjgao maybe if we pull just the items in the feature section, or anything with a news label or something. Not sure how to do the image part, but we could potentially scrape the whole description of the PR including figures

@jjgao
Copy link
Member Author

jjgao commented Dec 2, 2019

@inodb I like the idea of adding a news label. Maybe automatically generate a news PR and then we can manually add screenshots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants