Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable support for posted query data #6878

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

alisman
Copy link
Contributor

@alisman alisman commented Dec 3, 2019

Portal queries often contain too much data to represent in URL. In the past the portal allowed users to post query data to the results page, which would treat posted parameters the same as if they were in URL. We stopped support for this when we switched to SPA. This PR (and an associated frontend PR) will resume this feature.

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but should we have some test to confirm that it's working somewhere?

@alisman
Copy link
Contributor Author

alisman commented Dec 4, 2019

@inodb yes. this is actually only the first step. frontend needs to then process this. so, i will put in a test when i wire that up in frontend PR.

@alisman alisman merged commit f67112e into cBioPortal:master Dec 4, 2019
@alisman alisman deleted the handlePost branch December 4, 2019 20:07
@pvannierop
Copy link
Contributor

@alisman @inodb I think that we have to make 2 tests:

  1. Test correct response of backend to POST request.
  2. Correct handling of results of POST request by the frontend.

I think that 1. should be part of this PR. I will look at this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants