Allow dots in id validation (for gene sets) #7205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjgao this has been open for 25 days, and it is trivial. Can we get it merged? |
rmadupuri
approved these changes
Mar 16, 2020
|
@Sjoerd-van-Hagen sorry for the delay! This looks good @jjgao can we merge it? |
|
@rmadupuri thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pvannierop introduced a bug when refactoring the validation of gene sets (here). He was assuming the allowed characters for gene set IDs are
A-Za-z0-9_-, but he was missing the.. This PR corrects this issue.