Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test failure fixes #7485

Merged
merged 1 commit into from
May 12, 2020
Merged

Conversation

n1zea144
Copy link
Contributor

@n1zea144 n1zea144 commented May 11, 2020

Fixes one exception and a test failure while running unit tests in core:

  • Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'cacheMapUtil': Invocation of init method failed; nested exception is org.apache.ibatis.builder.IncompleteElementException: Could not find SQL statement to include with refid 'org.cbioportal.persistence.mybatis.GeneMapper.select'

This one is solved by setting mapperLocations in dao context file.

  • TestDaoTextCache.testDaoCaseList:82 expected: but was:

I fixed this by setting the time zone of the java code to UTC which seems to be the default time zone of MySQL installations. This could be problematic if local installations change the default timezone.

Per @pvannierop good suggestion - set default values for db test database inside applicationContext-dao.xml. This also allows travis command to be shortened.

@n1zea144 n1zea144 added the cl-bug Bug section of changelog. Bug fix label May 11, 2020
@n1zea144 n1zea144 requested review from inodb and dippindots May 11, 2020 16:42
@n1zea144 n1zea144 removed the request for review from dippindots May 12, 2020 12:40
Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@n1zea144 n1zea144 merged commit 6b2db8a into cBioPortal:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl-bug Bug section of changelog. Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants