Accelerate generic assay endpoint response speed #7617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippindots
commented
Jun 15, 2020
Comment on lines
+78
to
+90
| List<GenericAssayAdditionalProperty> additionalProperties = genericAssayRepository.getGenericAssayAdditionalproperties(distinctStableIds); | ||
| for (GenericAssayMeta meta : metaData) { | ||
| int geneticEntityId = genericAssayRepository.getGeneticEntityIdByStableId(meta.getStableId()); | ||
| String stableId = meta.getStableId(); | ||
| HashMap<String, String> map = new HashMap<>(); | ||
| for (HashMap<String, String> data : genericAssayRepository.getGenericAssayMetaPropertiesMap(geneticEntityId)) { | ||
| map.put(data.get("key"), data.get("value")); | ||
| List<GenericAssayAdditionalProperty> filteredAdditionalProperties = additionalProperties | ||
| .stream() | ||
| .filter(additionalProperty -> additionalProperty.getStableId().equals(stableId)) | ||
| .collect(Collectors.toList()); | ||
| for (GenericAssayAdditionalProperty additionalProperty : filteredAdditionalProperties) { | ||
| map.put(additionalProperty.getName(), additionalProperty.getValue()); | ||
| } | ||
| metaResults.add(new GenericAssayMeta(meta.getEntityType(), meta.getStableId(), map)); | ||
| meta.setGenericEntityMetaProperties(map); | ||
| metaResults.add(meta); |
There was a problem hiding this comment.
Main change is at here: we call function getGenericAssayAdditionalproperties once instead of calling N times getGeneticEntityIdByStableId and getGenericAssayMetaPropertiesMap (N is the number of stable ids).
dippindots
force-pushed
the
speed-up-generic-assay
branch
from
3ff9832
to
d756725
Compare
n1zea144
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7448
Result: take
ccle_broad_2019as an example, response time dropped from9s-10sto0.3-0.5s.This pr will address the issue that causes the slowness of generic assay endpoint.
The issue is: the mybatis mapper will be called (2 * number of stable ids) times. So the response speed is very slow.
Describe changes proposed in this pull request: