Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update session and matchminer endpoints #7672

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Update session and matchminer endpoints #7672

merged 1 commit into from
Jul 8, 2020

Conversation

kalletlak
Copy link
Member

This pr is continuation to #7653

Changes:

  1. path for session api's are changed from /proxy/session to /session
  2. path for matchminer api's are changed from /proxy/matchminer to /matchminer

@kalletlak kalletlak requested review from n1zea144 and inodb July 8, 2020 13:09
@kalletlak kalletlak mentioned this pull request Jul 8, 2020
Merged
inodb
inodb approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

This looks like a good solution to me

@inodb
Copy link
Member

inodb commented Jul 8, 2020

localdb failure seems unrelated

@inodb inodb merged commit 0fdeff3 into cBioPortal:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodb inodb inodb approved these changes

@n1zea144 n1zea144 Awaiting requested review from n1zea144

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalletlak @inodb