Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beginning of Redis cache for persistence feature #7680

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Beginning of Redis cache for persistence feature #7680

merged 1 commit into from
Jul 9, 2020

Conversation

sheridancbio
Copy link
Contributor

  • add redisson dependency (ver. 3.13.2) to persistence module
  • add context scanning references where appropriate
  • for now .. hardcode the CacheEnabledConfig to always be enabled
  • cache manager and client constructed in CustomRedisCachingProvider.java
  • cripple the EhCacheStatistics for now .. we need to reconfigure this to support redis
  • comment out all beans in applicationContext-ehcache.xml for now .. we need to figure out how to make them swappable with redis
  • added logging test to CancerTypeController (needs to be reverted)

Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • a
  • b

Checks

  • Runs on heroku
  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

@sheridancbio
Beginning of Redis cache for persistence feature
b9c2edc 
- add redisson dependency (ver. 3.13.2) to persistence module
- add context scanning references where appropriate
- for now .. hardcode the CacheEnabledConfig to always be enabled
- cache manager and client constructed in CustomRedisCachingProvider.java
- cripple the EhCacheStatistics for now .. we need to reconfigure this to support redis
- comment out all beans in applicationContext-ehcache.xml for now .. we need to figure out how to make them swappable with redis
- added logging test to CancerTypeController (needs to be reverted)
@sheridancbio sheridancbio merged commit e1291ed into cBioPortal:redis-cache-dev Jul 9, 2020
@sheridancbio sheridancbio mentioned this pull request Jul 9, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sheridancbio