Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison for treatment response data #7996

Merged
merged 1 commit into from Oct 21, 2020
Merged

Fix comparison for treatment response data #7996

merged 1 commit into from Oct 21, 2020

Conversation

kalletlak
Copy link
Member

@kalletlak kalletlak commented Oct 21, 2020 •
edited by inodb

Fix #7942. Update group filtering criteria while calculating expression enrichments

dippindots
dippindots approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kalletlak for fixing this! This looks right to me!

inodb
inodb approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@inodb inodb added the bug label Oct 21, 2020
@inodb inodb changed the title Update group filtering criteria while calculating expression enrichments Fix comparison for treatment data Oct 21, 2020
@inodb inodb changed the title Fix comparison for treatment data Fix comparison for treatment response data Oct 21, 2020
@inodb inodb merged commit fce8bdb into cBioPortal:master Oct 21, 2020
@inodb inodb mentioned this pull request Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodb inodb inodb approved these changes

@dippindots dippindots dippindots approved these changes

@jjgao jjgao Awaiting requested review from jjgao

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

comparison is not working for treatment response data
3 participants
@kalletlak @inodb @dippindots