Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup session-service controller #8864

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Cleanup session-service controller #8864

merged 2 commits into from
Aug 31, 2021

Conversation

kalletlak
Copy link
Member

No description provided.

Luke-Sikina
Luke-Sikina approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@Luke-Sikina Luke-Sikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few tiny questions and revisions.

web/src/main/java/org/cbioportal/web/SessionServiceController.java Outdated Show resolved Hide resolved
web/src/main/java/org/cbioportal/web/SessionServiceController.java Outdated Show resolved Hide resolved
web/src/main/java/org/cbioportal/web/SessionServiceController.java Outdated Show resolved Hide resolved
web/src/main/java/org/cbioportal/web/SessionServiceController.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jjgao jjgao temporarily deployed to cbioportal-ss-update-4nujea880 August 30, 2021 17:26 Inactive
@dippindots
Copy link
Member

@Luke-Sikina I have addressed comments in this commit, could I get your review again? Thanks!

@Luke-Sikina Luke-Sikina self-requested a review August 31, 2021 14:47
@inodb inodb added the cleanup label Aug 31, 2021
@inodb inodb merged commit d81ef12 into cBioPortal:master Aug 31, 2021
jagnathan pushed a commit to pughlab/cbioportal that referenced this pull request Nov 8, 2023
@kalletlak @jagnathan
Cleanup session-service controller (cBioPortal#8864)
1771ae8 
Co-authored-by: Gaofei Zhao <gzd23@mail.missouri.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke-Sikina Luke-Sikina Luke-Sikina approved these changes

@n1zea144 n1zea144 Awaiting requested review from n1zea144

@inodb inodb Awaiting requested review from inodb

@dippindots dippindots Awaiting requested review from dippindots

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kalletlak @dippindots @Luke-Sikina @jjgao @inodb