Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in importer and revisit ref genome in validator #9102

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

SRodenburg
Copy link

@SRodenburg SRodenburg commented Dec 9, 2021

The validator and importer Java backend code are rather confusing on what syntax to use to indicate an alternative genome build (e.g. GRCh38/hg38 or GRCm38/mm10 for mouse). There is a mixed and ambiguous usage of the terms "genome build" and "reference genome" throughout the code.

  • Validator now checks that meta_study.txt in (optional) field reference_genome contains one of hg19, hg38, mm10 and else uses the values specified in portal.properties.
  • Validator now checks for MAF files that the column NCBI_Build contains a value that is consistent with the specified reference_genome value, thus GRCh37 for hg19 studies etc.
  • some code cleaning to make this logic better comprehensible.

Already some time ago I looked into this but we never sorted this out: cBioPortal/cbioportal-frontend#3073

There is also an accommodating PR from @pvannierop in frontend. (cBioPortal/cbioportal-frontend#4084)

This partially fixes this issue as well: cBioPortal/icebox#115

@SRodenburg SRodenburg changed the title fix bug in import and revisit ref genome in validator fix bug in importer and revisit ref genome in validator Dec 9, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SRodenburg
Copy link
Author

@inodb happy new year! Can we merge this one?

@inodb inodb added the cleanup label Jan 3, 2022
@inodb
Copy link
Member

inodb commented Jan 3, 2022

@SRodenburg happy new year! Can this be merged independently of the other PRs mentioned in the description (e.g. the frontend)

@inodb inodb added bug and removed cleanup labels Jan 3, 2022
@inodb inodb merged commit d7b33c5 into cBioPortal:master Jan 3, 2022
@inodb inodb added cl-bug Bug section of changelog. Bug fix and removed bug labels Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl-bug Bug section of changelog. Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants