fix bug in importer and revisit ref genome in validator #9102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validator and importer Java backend code are rather confusing on what syntax to use to indicate an alternative genome build (e.g. GRCh38/hg38 or GRCm38/mm10 for mouse). There is a mixed and ambiguous usage of the terms "genome build" and "reference genome" throughout the code.
reference_genome
contains one ofhg19
,hg38
,mm10
and else uses the values specified inportal.properties
.NCBI_Build
contains a value that is consistent with the specifiedreference_genome
value, thusGRCh37
forhg19
studies etc.Already some time ago I looked into this but we never sorted this out: cBioPortal/cbioportal-frontend#3073
There is also an accommodating PR from @pvannierop in frontend. (cBioPortal/cbioportal-frontend#4084)
This partially fixes this issue as well: cBioPortal/icebox#115