Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change comparison page na terms delimiter #9462

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

leexgh
Copy link
Member

@leexgh leexgh commented Apr 14, 2022

Part of: #9413
Change na delimiter to "|" in backend

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@leexgh leexgh requested a review from inodb April 14, 2022 18:28
@@ -194,9 +194,9 @@ skin.show_settings_menu=
```

## Customize "NA" values in group comparison
Customize "NA" category in group comparison, for example "NA" and "unknown", all values are treated as "NA" and could be shown or hidden together on comparison page.
Customize "NA" category in group comparison, for example "NA" and "unknown", all values are treated as "NA" and could be shown or hidden together on comparison page. Values are separated by "|".
Copy link
Member Author

@leexgh leexgh Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talk with Brooke and decide to change to | instead of ,

@inodb inodb merged commit 5b0417d into cBioPortal:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants