Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Charge Buff, Cleave Buff, Power Attack Buff to Buff Duration Exception. #1116

Closed
caloyers opened this issue Jul 23, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@caloyers
Copy link

caloyers commented Jul 23, 2024

Is your feature request related to a problem?

I cant manually add them in buff duration exception as the search for these does not appear.

Describe the solution you'd like

Add the following to the Buff Duration Exception(Bag of Tricks/Other Multipliers) as this three is hidden in the list.

Charge buff: f36da144a379d534cad8e21667079066
Cleave Penalty Buff(AC Penalty): 914b04c279e3d3447848fecf5796cdcd
Power Attack Buff: bfe8300529214c7ca4ae0024f834f085

Charge buff penalty disables activation of stealth mode and even invisibility will trigger an attack from enemies.

Describe alternatives you've considered

No response

Additional context

No response

@caloyers caloyers added the enhancement New feature or request label Jul 23, 2024
@caloyers caloyers changed the title <title>Include Charge Buff, Cleave Buff, Power Attack Buff to Buff Duration Exception. Include Charge Buff, Cleave Buff, Power Attack Buff to Buff Duration Exception. Jul 23, 2024
@xADDBx
Copy link
Collaborator

xADDBx commented Jul 25, 2024

Wait what.

There's buffs that are included but aren't visible in the exclusion editor?

@CasDragon thoughts?

@CasDragon
Copy link
Collaborator

I'm like 60% sure those buffs aren't being affected by the Duration Multiplier to being with, which is why it's not showing up in the exclusion editor.

That said, I'm sure it would be fine if we manually added them to the exclusion list, so perhaps we do that, and we'll just call this "fixed"

@xADDBx
Copy link
Collaborator

xADDBx commented Jul 25, 2024

Huuh. I thought we filtered every hidden bp from being multiplied...

Filter for multiplier:

private static bool isGoodBuff(BlueprintBuff blueprint) => !blueprint.Harmful && !badBuffs.Contains(blueprint.AssetGuidThreadSafe);

List of buffs for Exclusion Editor:

_allBuffs = BlueprintLoader.Shared.GetBlueprints<BlueprintBuff>()
                    ?.Where(bp => !bp.IsHiddenInUI
                                  && !bp.IsClassFeature
                                  && !bp.Harmful)

@xADDBx
Copy link
Collaborator

xADDBx commented Jul 25, 2024

Try to see if the new version fixes your issue @caloyers

@caloyers
Copy link
Author

Thanks it fixed now. Please close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants