Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svgcheck removed -X #187

Closed
snorp opened this issue Feb 22, 2023 · 6 comments
Closed

svgcheck removed -X #187

snorp opened this issue Feb 22, 2023 · 6 comments

Comments

@snorp
Copy link

snorp commented Feb 22, 2023

This seems to break, amongst other things, svg generation in martinthomson/i-d-template
@snorp snorp mentioned this issue Feb 22, 2023
Closed
@cabo
Copy link
Owner

cabo commented Feb 22, 2023

In ietf-tools/svgcheck#32, Kesara said he was going to fix this.
If he doesn't, I can fix it here, of course.

@snorp
Copy link
Author

snorp commented Feb 22, 2023

Oh, hmm. I do not get the warning for -X in 0.7.1, but the generation still fails. 0.6.2 works. See martinthomson/i-d-template#364 (comment)

@cabo
Copy link
Owner

cabo commented Feb 22, 2023

svgcheck seems to have lost the ability to read from stdin.

@snorp
Copy link
Author

snorp commented Feb 22, 2023

Seems likely to be caused by this change: ietf-tools/svgcheck@ac1cc51#diff-ce7bd9cc13feace43ecfdaaa297442628841e2f13939fd19d986adff269031bb

@cabo
Copy link
Owner

cabo commented Feb 22, 2023

fixed in 1.6.24

@snorp
Copy link
Author

snorp commented Feb 22, 2023

Yup, confirmed that works.

@snorp snorp closed this as completed Feb 22, 2023
This was referenced Feb 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cabo @snorp