Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old C Interface unittests are commented out #39

Open
cadop opened this issue Nov 28, 2022 · 0 comments
Open

Old C Interface unittests are commented out #39

cadop opened this issue Nov 28, 2022 · 0 comments
Labels
build Issues relating to the build process CI/CD documentation Improvements or additions to documentation

Comments

@cadop
Copy link
Owner

cadop commented Nov 28, 2022

CMake config comments out c_interface tests:

dhart/src/CMakeLists.txt

Lines 416 to 422 in 8aa1655

# ${C_TEST_DRIVER_DIR}/embree_raytracer_cinterface.cpp
# ${C_TEST_DRIVER_DIR}/objloader_cinterface.cpp
# ${C_TEST_DRIVER_DIR}/analysis_C_cinterface.cpp
# ${C_TEST_DRIVER_DIR}/pathfinder_C_cinterface.cpp
# ${C_TEST_DRIVER_DIR}/view_analysis_cinterface.cpp
# ${C_TEST_DRIVER_DIR}/visibility_graph_cinterface.cpp
# ${C_TEST_DRIVER_DIR}/spatialstructures_C_cinterface.cpp

Need to look back and find when this happened and if all tests are covered by other ones, as the interface seems to be an older version:

status = LoadOBJ(obj_path_str.c_str(), obj_length, rot[0], rot[1], rot[2], &loaded_obj);

@cadop cadop added documentation Improvements or additions to documentation CI/CD build Issues relating to the build process labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues relating to the build process CI/CD documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant