Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new Environments! #513

Open
theoneguy-real opened this issue Mar 18, 2024 · 6 comments
Open

Add the new Environments! #513

theoneguy-real opened this issue Mar 18, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@theoneguy-real
Copy link

theoneguy-real commented Mar 18, 2024

There's been a few new environments after the last one on the list in the app, and I think they should be added.

New environments would mean more places to make maps with even cooler lightshows!

The ones not added are:
Daft Punk
Imagine Dragons V2
Electronic Mixtape
Fall Out Boy
Hip-Hop Mixtape
Lady Gaga
Linkin Park V2
Lizzo
"NiceEnvironment"
OST 4/5/6 Environments
Panic! At The Disco V2
Rock Mixtape
Queen
The Rolling Stones
The Weeknd
"WeaveEnvironment"

@theoneguy-real theoneguy-real added the enhancement New feature or request label Mar 18, 2024
@Top-Cat
Copy link
Contributor

Top-Cat commented Mar 18, 2024

Feel free to open a PR when you've done it :)

@theoneguy-real
Copy link
Author

Feel free to open a PR when you've done it :)

wait what does that mean
i know what a pull request is, but i can't add the environments myself
i'm not that talented

@valentinegb
Copy link

Feel free to open a PR when you've done it :)

I couldn't find any documentation in this project for how environments are implemented

@XAce1337manX
Copy link
Collaborator

Documentation doesn't exist. It's pretty much all from figuring out the code in the Platforms folder.

Though keep in mind we're looking at updating CM to support v4 format and it's likely to cause merge conflicts with any significant work with v3 lighting if you're planning on it.

@Caeden117
Copy link
Owner

Adding platforms is a lot of work. Adding proper v3 support will almost certainly require a complete rewrite of everything platforms related. Adding a v3 lighting workflow that comes close to matching the Official editor will be extremely difficult and time consuming, nigh on impossible.

There are better priorities we'd like to focus on. People interested in newer environments can use the Official editor. It's really the best in class for everything with the latest lighting system.

@valentinegb
Copy link

People interested in newer environments can use the Official editor.

I can't use the official editor... it's not on Mac. But alright, I can understand that adding the new environments are not a high priority right now with what you guys just said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants