-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing for Linux, Windows and Darwin #26
Comments
@LyubomirT Any idea on how to optimize in node? ReadFileSync writes the contents of each file into memory, but i believe it would be better to implement this with streams. I haven't been successful so far though... You can see the failed implementation merged in #36 |
Streaming actually sounds like a great idea, I'll see what I can do and will try to add the implementation to my fork if I succeed. Can't guarantee anything for now, though. |
However, personally, I don't think optimization will matter much here, since all the files combined likely won't eat more than 10KB of memory. |
True. Although apart from a lower memory usage, we would be able to boost runtime performance. |
Alright. Is it working fine on your side? |
Glad to hear it works well! Can't really use it in Windows 11 for some reason, but maybe it's just the merge conflict. |
Perhaps your fork is outdated? 🤔 |
It was indeed outdated, but due to how late I noticed that, I got a merge conflict, and, well, it all got broken. === I managed to get your version to work, though :D |
I'll hold off on writing tests until I've added a few more features. PRs still welcome though ❤️ |
@LyubomirT lets move this to #46 :> |
Including this is v2 in Go. For v2, I think it'd be great if we had some blackbox testing with docker and bash too. |
Testing for the 3 major OSes (Linux, Windows & Darwin).
PR welcome
Track
The text was updated successfully, but these errors were encountered: