Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to golangci-lint #287

Closed
iawia002 opened this issue Aug 23, 2019 · 2 comments · Fixed by #289
Closed

migrate to golangci-lint #287

iawia002 opened this issue Aug 23, 2019 · 2 comments · Fixed by #289
Assignees
@iawia002

Comments

@iawia002
Copy link

golangci-lint is faster than gometalinter, easier to use, and rich in configuration. And since gometalinter is DEPRECATED for now, we should migrate from gometalinter to golangci-lint

related: #31

/cc @ddysher @kdada
@iawia002 iawia002 mentioned this issue Aug 23, 2019
Open
@ddysher
Copy link
Member

ddysher commented Aug 23, 2019

LGTM

@iawia002
Copy link
Author

/assign

@iawia002 iawia002 mentioned this issue Aug 23, 2019
Merged
@iawia002 iawia002 mentioned this issue Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iawia002 iawia002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(*): migrate to golangci-lint iawia002/nirvana
2 participants
@ddysher @iawia002