chore(*): migrate to golangci-lint

[iawia002]

What this PR does / why we need it:

close #287

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @your-reviewer

Release note:

NONE

[iawia002]

/cc @kdada

[kdada]

The implementation is not correct. This method makes users have no way to check if the response supports http.CloseNotifier. Do you have time to fix this in a new PR?

[iawia002]

So I deleted it directly in this PR? As mentioned in #288

[kdada]

I mean that the response may not implement http.CloseNotifier.

The method should be separated into two parts:

type response struct {...}


type responseWithCloseNotify struct {
    *response
}

func (c *responseWithCloseNotify) CloseNotify() <-chan bool {...}

Then wrap response with the new struct.

rw = &response{}

if _, ok:=rw.(http.CloseNotifier); ok {
    rw = &responseWithCloseNotify{rw}
}

If the method is removed from the go library in the future, the response still works.

[iawia002]

You mean still keep this function? As you replied Just do it. in #288 I thought we can just delete this function.

[kdada]

It seems that we need to retain it because of the behavior of go library.

[iawia002]

Fine, I will fix this in a new PR

[kdada]

LGTM for the rest.

[kdada]

/lgtm

[caicloud-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kdada]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment