Add gocyclo and golint into gometalinter

[jimexist]

What is the issue about:
Adding more linter coverage.

What happened:
Golint and gocyclo could not be added because there are some pending fixes to be made.

What you expected to happen:
See lint errors.

Anything else we need to know:
@caicloud/review-framework esp. the router implementations, there are some complex functions that need to be refactored.

[jimexist]

router/router_test.go:81::warning: cyclomatic complexity 20 of function TestParse() is high (> 10) (gocyclo)
router/basic.go:151::warning: cyclomatic complexity 17 of function (*Progeny).AddRouter() is high (> 10) (gocyclo)
router/router_test.go:167::warning: cyclomatic complexity 14 of function TestRouter() is high (> 10) (gocyclo)
router/string.go:48::warning: cyclomatic complexity 11 of function (*StringNode).Merge() is high (> 10) (gocyclo)
router/router.go:141::warning: cyclomatic complexity 11 of function SegmentToRouter() is high (> 10) (gocyclo)
router/router.go:235::warning: cyclomatic complexity 11 of function Reorganize() is high (> 10) (gocyclo)
router/basic.go:78:1:warning: comment on exported type CharRouter should be of the form "CharRouter ..." (with optional leading article) (golint)
router/basic.go:150:1:warning: comment on exported method Progeny.AddRouter should be of the form "AddRouter ..." (golint)
router/router.go:34:6:warning: type name will be used as router.RouterKind by other packages, and that stutters; consider calling this Kind (golint)
router/router.go:88:2:warning: comment on exported const FullMatchTarget should be of the form "FullMatchTarget ..." (golint)
router/router.go:91:2:warning: comment on exported const TailMatchTarget should be of the form "TailMatchTarget ..." (golint)
router/router.go:152:10:warning: if block ends with a return statement, so drop this else and outdent its block (golint)
router/router_test.go:220:10:warning: should not use basic type string as key in context.WithValue (golint)
router/router_test.go:232:9:warning: should not use basic type string as key in context.WithValue (golint)
router/router_test.go:244:10:warning: should not use basic type string as key in context.WithValue (golint)

👆 see above

[jimexist]

see #29 and #30

[jimexist]

also see results directly here

[ddysher]

@jimexist is it still a problem now?

[jimexist]

yes - no update yet @ddysher

[ddysher]

ok, can we lower the priority and clean up later?

[caicloud-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[caicloud-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[iawia002]

Migrated to golangci-lint in #287

/close