Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint): add gometalinter #29

Merged
merged 1 commit into from
Nov 17, 2017
Merged

feat(lint): add gometalinter #29

merged 1 commit into from
Nov 17, 2017

Conversation

jimexist
Copy link
Contributor

What this PR does
add gometalinter to project

why we need it
better code quality

Special notes for your reviewer:

@jimexist jimexist self-assigned this Nov 17, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.776% when pulling 7826816 on add-linter into 4ed4b8b on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.776% when pulling 7826816 on add-linter into 4ed4b8b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.776% when pulling 7826816 on add-linter into 4ed4b8b on master.

ddysher
ddysher approved these changes Nov 17, 2017
View reviewed changes
Copy link
Member

@ddysher ddysher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddysher ddysher merged commit 16ac175 into master Nov 17, 2017
@jimexist jimexist mentioned this pull request Nov 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddysher ddysher ddysher approved these changes

@walktall walktall Awaiting requested review from walktall

@kdada kdada Awaiting requested review from kdada

@xiaoq17 xiaoq17 Awaiting requested review from xiaoq17

Assignees

@jimexist jimexist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jimexist @coveralls @ddysher