-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add more linters #30
Conversation
2 similar comments
Please use our commit style
Please remove such commits
What's the criteria for adding a new linter? |
@ddysher can we ignore the specific commit messages, if we enforce squash commits for pull requests? So that:
|
criteria for adding linters:
|
@jimexist Please fork this repo and create the PR from your forked repo. |
Good catch! @supereagle
|
@jimexist Since there is already conflict, can we close the PR and then create a new PR from your own fork? |
What this PR does
add more linters
why we need it
cover more lint cases
Special notes for your reviewer: