Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish new NPM package with the license #9

Closed
jinwoo opened this issue Jan 5, 2018 · 5 comments
Closed

Please publish new NPM package with the license #9

jinwoo opened this issue Jan 5, 2018 · 5 comments

Comments

@jinwoo
Copy link

jinwoo commented Jan 5, 2018

Commit 7caec88 added the license and upped the version to 1.2.6 but the latest NPM version in https://www.npmjs.com/package/log-driver is still 1.2.5.

We are using an automated tool for checking licenses in our packages and their dependencies. The tool works best when packages specify their licenses in the license field of the package.json files, as written in https://docs.npmjs.com/files/package.json#license.

It'd be great if you could publish a new NPM version with the valid license field in package.json.

Thanks!

@jinwoo
Copy link
Author

jinwoo commented Jan 8, 2018

@cainus Can you please help us by publishing an npm package with the latest version here on GitHub?

@GantMan
Copy link

GantMan commented Feb 8, 2018

+1 - license is not current with NPM

@cainus
Copy link
Owner

cainus commented Feb 9, 2018

@jinwoo @GantMan just published!

@cainus cainus closed this as completed Feb 9, 2018
@jinwoo
Copy link
Author

jinwoo commented Feb 9, 2018

Thank you, @cainus !

@jinwoo
Copy link
Author

jinwoo commented Feb 9, 2018

@cainus Now we're getting more issues with packages that have problematic licenses. They all originate from codecov-io. I think codecov-io is needed only for development and should be put into devDependencies instead of dependencies.

Could you please move it to devDependencies and publish a new npm version?

Thanks!

> jsgl --local .

Checking package.json...

(no license): forever-agent@0.5.2
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> forever-agent@0.5.2

(no license): combined-stream@0.0.7
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> form-data@0.1.4 -> combined-stream@0.0.7

(no license): delayed-stream@0.0.5
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> form-data@0.1.4 -> combined-stream@0.0.7 -> delayed-stream@0.0.5

(no license): mime@1.2.11
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> form-data@0.1.4 -> mime@1.2.11

(no license): assert-plus@0.1.5
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> http-signature@0.10.1 -> assert-plus@0.1.5

(no license): asn1@0.1.11
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> http-signature@0.10.1 -> asn1@0.1.11

(no license): ctype@0.5.3
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> http-signature@0.10.1 -> ctype@0.5.3

(no license): oauth-sign@0.4.0
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> oauth-sign@0.4.0

(no license): aws-sign2@0.5.0
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> request@2.42.0 -> aws-sign2@0.5.0

Public Domain: jsonify@0.0.0
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> urlgrey@0.4.0 -> tape@2.3.0 -> jsonify@0.0.0

(no license): split@0.2.10
  @google-cloud/common@0.16.0 -> log-driver@1.2.6 -> codecov.io@0.0.1 -> urlgrey@0.4.0 -> tape@2.3.0 -> split@0.2.10

11 non-green licenses found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants