Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor KeyExists to avoid logging errors when key not found #5

Open
caiodallaqua opened this issue Jan 26, 2024 · 0 comments
Open
Labels
refactor Improvements for better maintenability

Comments

@caiodallaqua
Copy link
Owner

DoD: Being able to call KeyExists for a key that is not in the DB without any logging errors.

The logged error points to Get, which makes it hard to debug. It should not log since checking errors is part of the logic here (due to Badger). Log example: level=ERROR msg="Key not found" trace=vectoria:src:internal:storage:Get

@caiodallaqua caiodallaqua added the refactor Improvements for better maintenability label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements for better maintenability
Projects
None yet
Development

No branches or pull requests

1 participant