Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cairo top bar and icon tray showing in full screen apps/videos #350

Closed
zbholman opened this issue Feb 21, 2020 · 19 comments
Closed

Cairo top bar and icon tray showing in full screen apps/videos #350

zbholman opened this issue Feb 21, 2020 · 19 comments
Assignees
Labels
Milestone

Comments

@zbholman
Copy link

When watching a video and enabling full screen view, the Cairo app tray and top menu bar still show.

@dremin
Copy link
Collaborator

dremin commented Feb 21, 2020

What application are you using that is not being detected as full screen? What version of Cairo and Windows?

@zbholman
Copy link
Author

zbholman commented Feb 21, 2020

As of yesterday, the latest version (checked for updates and none available).

I'm not at my computer right now, but I was using the latest version of Firefox, and Windows 10 (not sure which release exactly).

I can provide more details when I get home and have access to the machine I found this issue with.

Edit: This was working in a previous release about a month ago or so.

@dremin
Copy link
Collaborator

dremin commented Feb 21, 2020

Interesting, I use Firefox to test the full screen awareness and it works on my machines. Any additional information you can provide, especially regarding Firefox version/config/addons would help!

@dremin
Copy link
Collaborator

dremin commented Feb 22, 2020

@zbholman I am trying a new full screen detection method, could you please try this build and see if it works as expected for you?

@TLCPlusPlus
Copy link

TLCPlusPlus commented Mar 9, 2020

@zbholman I am trying a new full screen detection method, could you please try this build and see if it works as expected for you?

Same issue, but on Brave browser. I used the build you linked to, no change in full screen behavior.

"Brave is up to date
Version 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)"

Edit: tried Firefox 73.0.1 (64-bit) just for kicks, it doesnt work on it either.

@dremin
Copy link
Collaborator

dremin commented Mar 9, 2020

I'm at a bit of a loss here.. Can you increase logging level to Debug in Cairo Settings > Advanced, restart Cairo, then try to fullscreen those browsers? Afterwards, could you please attach the current log file in %localappdata%\Cairo_Development_Team\Logs? Thanks!

@TLCPlusPlus
Copy link

03-09-2020.log.txt

Made it a .log.txt extention cause github doesnt like .log, should open just the same either way.

Made sure to be in Debug logging mode, restared Cario and tested both browsers. Hopefully it contains something useful because I poked around it and all I can see is my wifi point and my tray programs along with other misc things.

@dremin
Copy link
Collaborator

dremin commented Mar 10, 2020

@VirusRenamon thanks! Question- are you using a scaling setting different than 100% in Display settings?

@TLCPlusPlus
Copy link

@dremin Yes and no, I am using 175% on my secondary monitor and 100% on my main monitor.

@dremin
Copy link
Collaborator

dremin commented Mar 10, 2020

@VirusRenamon Which monitor are you full-screen-ing your browser on?

@TLCPlusPlus
Copy link

@dremin the main monitor, using 100%

@dremin
Copy link
Collaborator

dremin commented Mar 10, 2020

@VirusRenamon Thanks for the details! I think I got it, can you try this build?

@TLCPlusPlus
Copy link

@dremin confirmed fixed for both browsers I used.

@dremin
Copy link
Collaborator

dremin commented Mar 10, 2020

@VirusRenamon Great! Thanks for helping narrow this one down!

@dremin dremin closed this as completed Mar 23, 2020
@dremin dremin self-assigned this Mar 23, 2020
@dremin dremin added the Bug label Mar 23, 2020
@dremin dremin added this to the Milestone 3 milestone Mar 23, 2020
@katawajojo
Copy link

I just want to post and say this bug has popped back up.

@dremin
Copy link
Collaborator

dremin commented Oct 22, 2020

Did it begin after installing a specific update?

@katawajojo
Copy link

it began about 3 updates ago or so. I don't know exactly which one it was

@dremin
Copy link
Collaborator

dremin commented Oct 25, 2020

@katawajojo I did some more testing and found an issue that affected a few specific apps (such as Chrome and Edge). If you would like to see if the fix for this issue helps your scenario, you can try installing this build.

@katawajojo
Copy link

Yes, this build fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants