Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

将 app.Error 等函数移到 main 包中 #18

Closed
caixw opened this issue Jul 24, 2016 · 0 comments
Closed

将 app.Error 等函数移到 main 包中 #18

caixw opened this issue Jul 24, 2016 · 0 comments
Assignees
@caixw
Labels
wontfix
Milestone
v3.0

Comments

@caixw
Copy link
Owner

caixw commented Jul 24, 2016

input, output 等子包应该只向调用方反馈信息，但是信息具体输出到哪儿，应该由调用方来决定。

目前 output 包中在调试模式下，会直接调用 app.Info 输出一条提示信息，以及 500 错误时，会调用 app.Error 输出一条错误信息，是否应该像 input 一条传递一个 log.Logger 变量来获取这些信息！
@caixw caixw added the wontfix label Jul 24, 2016
@caixw caixw added this to the v3.0 milestone Jul 24, 2016
@caixw caixw self-assigned this Jul 24, 2016
@caixw caixw closed this as completed in 49c0168 Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caixw caixw

Labels
wontfix
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@caixw