GH2696: Update Cake support for GitReleaseManager #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cake-build/cake-team would be good to get a review of this, thanks! |
devlead
requested changes
Jan 17, 2020
src/Cake.Common/Tools/GitReleaseManager/Open/GitReleaseManagerMilestoneOpener.cs
Outdated
Show resolved
Hide resolved
src/Cake.Common/Tools/GitReleaseManager/Discard/GitReleaseManagerDiscarder.cs
Outdated
Show resolved
Hide resolved
src/Cake.Common/Tools/GitReleaseManager/Label/GitReleaseManagerLabeller.cs
Outdated
Show resolved
Hide resolved
src/Cake.Common/Tools/GitReleaseManager/Publish/GitReleaseManagerPublisher.cs
Outdated
Show resolved
Hide resolved
src/Cake.Common/Tools/GitReleaseManager/AddAssets/GitReleaseManagerAssetsAdder.cs
Outdated
Show resolved
Hide resolved
src/Cake.Common/Tools/GitReleaseManager/Close/GitReleaseManagerMilestoneCloser.cs
Outdated
Show resolved
Hide resolved
Not entirely sure what this wasn't done initially, but I think it makes sense to apply this refactoring now. Makes it easier to add the three new common options.
All of these will default to false, unless otherwise specified.
Add indentation which seemed to be missing
GitReleaseManager is deprecating support for using username/password when connecting to GitHub, and as such, the Cake Aliases that provide this functionality should also be marked as Obsolete.
Add parsing of common arguments to each alias for GitReleaseManager, as well as tests for ensuring that they are being output when set.
Update tool pre-processor directive to use 0.10.2. Also switch away from using username/password version GRM Cake aliases, in favour of token version. And finally, added yaml configuration to enable new GRM features.
These were created by copying from the create and close methods.
Not sure how/why this wasn't implemented already across all the methods, but glad that it was caught here.
devlead
force-pushed
the
feature/GH-2696
branch
from
e38f8e0
to
b359473
Compare
|
@gep13 your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2696
If/when this is merged, we will need to make sure to switch to the
CAKE_GITHUB_TOKENenvironment variable.